Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security issue with handling of cookie-jar #177

Open
mkomitee opened this issue Mar 15, 2016 · 1 comment
Open

Security issue with handling of cookie-jar #177

mkomitee opened this issue Mar 15, 2016 · 1 comment

Comments

@mkomitee
Copy link

When ein authenticates to an ipython notebook server, under the hood it uses the curl and curls cookie-jar feature. This involves the creation of a file to store the cookies.

The file often ends up in $HOME/.emacs.d/request/curl-cookie-jar, but that's not always the case. The problem is, ein (and the underlying request library) doesn't do anything special to protect the files permissions.

If you use EIN from a host to which other untrusted users have access, they can steal and use the resulting cookies to execute code as you using your notebook server.

Can ein be modified to set a restrictive umask for the curl call?

@millejoh
Copy link

This is more an issue with tkf/emacs-request than it is with ein. Unfortunately, just like ein, tkf has not updated this project in 2 years. You can customize where requests stores cookies via the request-storage-directory variable and store the cookie jar in a directory that only you have access to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants