Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug in impersonation request #1742

Merged
merged 1 commit into from
Feb 8, 2022
Merged

fix bug in impersonation request #1742

merged 1 commit into from
Feb 8, 2022

Conversation

willzgli
Copy link
Collaborator

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind bug

What this PR does / why we need it:

  1. Exracting and valiating host and port by spliting string with
    keys is not reasonable. The original way will return a fake
    error with a valid host like http://192.168.1.11:8080/abc

  2. request dose not support insert header with impersonation informations

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@leoryu
Copy link
Contributor

leoryu commented Jan 15, 2022

@rootdeep please modify your commit meesage to fix(platform): xxxx format.

@leoryu
Copy link
Contributor

leoryu commented Jan 15, 2022

@songkane I think this pr will make your case doesn't work, please check.

1. Exracting and valiating host and port by spliting string with
   keys is not reasonable. The original way will return a fake
   error with a valid host like http://192.168.1.11:8080/abc

2. request dose not support insert header with impersonation informations

this patch fix above bugs.

By the way, add unit test
@leoryu leoryu merged commit ede0e48 into tkestack:master Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants