We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What happened: Fail to send alert messages via mail with tls enabled on a port other than 465.
What you expected to happen: Could send alert messages via mail with tls enabled on any port specified.
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?: pkg/notify/controller/messagerequest/smtp/send.go
if port == "465" { //via TLS conn, err := tls.Dial("tcp", addr, tlsConfig) if err != nil { return err } c, err = smtp.NewClient(conn, host) if err != nil { return err } } else { c, err = smtp.Dial(addr) if err != nil { return err } } defer c.Close() if err := c.Hello("localhost"); err != nil { return err } if port != "465" { if ok, _ := c.Extension("STARTTLS"); ok { if err := c.StartTLS(tlsConfig); err != nil { return err } } }
The code here uses port as a condition to determine whether to enable tls while we set it in other field actually. Environment:
kubectl version
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
What happened:
Fail to send alert messages via mail with tls enabled on a port other than 465.
What you expected to happen:
Could send alert messages via mail with tls enabled on any port specified.
How to reproduce it (as minimally and precisely as possible):
![smtp](https://user-images.githubusercontent.com/13358816/122911519-f6d3fb80-d389-11eb-8f4a-ba0236c0a7f3.PNG)
Anything else we need to know?:
pkg/notify/controller/messagerequest/smtp/send.go
The code here uses port as a condition to determine whether to enable tls while we set it in other field actually.
Environment:
kubectl version
):The text was updated successfully, but these errors were encountered: