fix(application): rm app phase chart fetched (#1763)

GaoXiaodong · xdonggao · web-flow · commit 97c8d80ea7ca · 2022-02-10T10:16:02.000+08:00
Co-authored-by: xdonggao &lt;xdonggao@tencent.com&gt;
diff --git a/api/application/types.go b/api/application/types.go
@@ -226,9 +226,6 @@ const (
 type AppPhase string
 
 const (
-	// ChartFetched means the chart to which the App refers
-	// has been fetched successfully
-	AppPhaseChartFetched AppPhase = "ChartFetched"
 	// ChartFetchedFailed means the chart to which the App
 	// refers could not be fetched.
 	AppPhaseChartFetchFailed AppPhase = "ChartFetchFailed"
diff --git a/api/application/v1/types.go b/api/application/v1/types.go
@@ -226,9 +226,6 @@ const (
 type AppPhase string
 
 const (
-	// ChartFetched means the chart to which the App refers
-	// has been fetched successfully
-	AppPhaseChartFetched AppPhase = "ChartFetched"
 	// ChartFetchedFailed means the chart to which the App
 	// refers could not be fetched.
 	AppPhaseChartFetchFailed AppPhase = "ChartFetchFailed"
diff --git a/pkg/application/controller/app/action/pull.go b/pkg/application/controller/app/action/pull.go
@@ -61,14 +61,6 @@ func Pull(ctx context.Context,
 			updateStatusFunc(ctx, app, &app.Status, newStatus)
 			return destfile, err
 		}
-		newStatus.Phase = applicationv1.AppPhaseChartFetched
-		newStatus.Message = ""
-		newStatus.Reason = ""
-		newStatus.LastTransitionTime = metav1.Now()
-		_, err := updateStatusFunc(ctx, app, &app.Status, newStatus)
-		if err != nil {
-			return destfile, err
-		}
 	}
 	return destfile, err
 }
diff --git a/pkg/application/controller/app/app_controller.go b/pkg/application/controller/app/app_controller.go
@@ -341,8 +341,6 @@ func (c *Controller) handlePhase(ctx context.Context, key string, cachedApp *cac
 		return c.syncAppFromRelease(ctx, cachedApp, app)
 	case applicationv1.AppPhaseRollbackFailed:
 		break
-	case applicationv1.AppPhaseChartFetched:
-		break
 	case applicationv1.AppPhaseChartFetchFailed:
 		break
 	case applicationv1.AppPhaseSyncFailed:

Original file line number	Diff line number	Diff line change
`@@ -61,14 +61,6 @@ func Pull(ctx context.Context,`
`61`	`61`	`updateStatusFunc(ctx, app, &app.Status, newStatus)`
`62`	`62`	`return destfile, err`
`63`	`63`	`}`
`64`		`- newStatus.Phase = applicationv1.AppPhaseChartFetched`
`65`		`- newStatus.Message = ""`
`66`		`- newStatus.Reason = ""`
`67`		`- newStatus.LastTransitionTime = metav1.Now()`
`68`		`- _, err := updateStatusFunc(ctx, app, &app.Status, newStatus)`
`69`		`- if err != nil {`
`70`		`- return destfile, err`
`71`		`- }`
`72`	`64`	`}`
`73`	`65`	`return destfile, err`
`74`	`66`	`}`