Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use coverage as multithreaded in pytest for correct results #59

Merged
merged 3 commits into from
Jul 4, 2024
Merged

Use coverage as multithreaded in pytest for correct results #59

merged 3 commits into from
Jul 4, 2024

Conversation

JasonGrace2282
Copy link
Member

@JasonGrace2282 JasonGrace2282 commented Jul 2, 2024 •
edited
Loading

Maybe I'm just salty because my PR dropped coverage by 30% ;)

@JasonGrace2282 JasonGrace2282 requested a review from a team as a code owner July 2, 2024 10:55
@JasonGrace2282 JasonGrace2282 marked this pull request as draft July 2, 2024 10:55
@JasonGrace2282 JasonGrace2282 marked this pull request as ready for review July 2, 2024 10:57
@JasonGrace2282
Copy link
Member Author

Would it be a good idea to add pytest-cov as a dev dependency? It seems like it would only be used for ci 🤔

@krishnans2006
Copy link
Member

Would it be a good idea to add pytest-cov as a dev dependency? It seems like it would only be used for ci 🤔

I think so - feels a bit awkward to pip install it when everything else uses pipenv.

krishnans2006
krishnans2006 requested changes Jul 3, 2024
View reviewed changes
Copy link
Member

@krishnans2006 krishnans2006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do ^

@JasonGrace2282
Copy link
Member Author

I added it to the pipenv CI category

@krishnans2006 krishnans2006 merged commit 75cf260 into tjcsl:master Jul 4, 2024
4 checks passed
@JasonGrace2282 JasonGrace2282 deleted the fix-coverage branch July 23, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krishnans2006 krishnans2006 krishnans2006 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JasonGrace2282 @krishnans2006