Skip to content

Commit 203752c

Browse files
committed
fix #281: enable 32 and 64 bit iisnode SxS on x64 machines
1 parent b95fcda commit 203752c

File tree

6 files changed

+1
-95
lines changed

6 files changed

+1
-95
lines changed

Diff for: src/config/iisnode_schema_x64_wow.xml

-60
This file was deleted.

Diff for: src/iisnode/iisnode.vcxproj

-1
Original file line numberDiff line numberDiff line change
@@ -384,7 +384,6 @@ copy /y $(ProjectDir)\..\config\* $(ProjectDir)\..\..\build\$(Configuration)\$(P
384384
<None Include="..\config\iisnode_schema_x64.xml">
385385
<SubType>Designer</SubType>
386386
</None>
387-
<None Include="..\config\iisnode_schema_x64_wow.xml" />
388387
<None Include="..\samples\configuration\hello.js" />
389388
<None Include="..\samples\configuration\iisnode.yml" />
390389
<None Include="..\samples\configuration\readme.htm">

Diff for: src/iisnode/iisnode.vcxproj.filters

-3
Original file line numberDiff line numberDiff line change
@@ -675,9 +675,6 @@
675675
<None Include="..\..\test\functional\www\124_node_config_override\iisnode.yml">
676676
<Filter>Tests\functional\www\124_node_config_override</Filter>
677677
</None>
678-
<None Include="..\config\iisnode_schema_x64_wow.xml">
679-
<Filter>Config</Filter>
680-
</None>
681678
<None Include="..\scripts\interceptor.js">
682679
<Filter>Scripts</Filter>
683680
</None>

Diff for: src/setup/iisnode-msi/customactions.wxi

+1-7
Original file line numberDiff line numberDiff line change
@@ -54,13 +54,7 @@
5454

5555
<?if $(var.isWin64) = "yes" ?>
5656
<CustomAction Id="AddIisnodeModuleRegistration"
57-
ExeCommand="[System64Folder]inetsrv\appcmd.exe install module /name:iisnode /image:&quot;[iisnoderootdir]iisnode.dll&quot; /preCondition:bitness64 /commit:apphost"
58-
Directory="TARGETDIR"
59-
Execute="deferred"
60-
Return="check"
61-
Impersonate="no"/>
62-
<CustomAction Id="AddIisnodeModuleRegistrationWow"
63-
ExeCommand="[System64Folder]inetsrv\appcmd.exe install module /name:iisnode /image:&quot;[iisnoderootdirwow]iisnode.dll&quot; /preCondition:bitness32 /commit:apphost"
57+
ExeCommand="[System64Folder]inetsrv\appcmd.exe install module /name:iisnode /image:&quot;%programfiles%\iisnode\iisnode.dll&quot; /commit:apphost"
6458
Directory="TARGETDIR"
6559
Execute="deferred"
6660
Return="check"

Diff for: src/setup/iisnode-msi/iisnode.wxs

-12
Original file line numberDiff line numberDiff line change
@@ -62,15 +62,8 @@
6262

6363
<Feature Id="iisnode4iis" Title="Hosting node.js applications in IIS 7.x" Level="1" Description="IIS 7.x native module for hosting node.js applications in IIS">
6464
<ComponentGroupRef Id="allfiles" />
65-
<Condition Level="0">WOW</Condition>
66-
</Feature>
67-
68-
<?if $(var.isWin64) = "yes" ?>
69-
<Feature Id="iisnode4iiswow" Title="Hosting node.js applications in IIS 7.x in WOW mode" Level="1" Description="IIS 7.x native module for hosting node.js applications in IIS in WOW mode">
7065
<ComponentGroupRef Id="allfileswow" />
71-
<Condition Level="0">NOT WOW</Condition>
7266
</Feature>
73-
<?endif?>
7467

7568
<?if $(var.ProjectName) = iisnode-msi-full ?>
7669
<WixVariable Id="WixUILicenseRtf" Value="$(var.ProjectDir)\License.rtf" />
@@ -104,12 +97,7 @@
10497

10598
<!-- install/rollback/uninstall iisnode module -->
10699

107-
<?if $(var.isWin64) = "yes" ?>
108-
<Custom Action="AddIisnodeModuleRegistration" After="RemoveIisnodeModuleRegistration">(REMOVE&lt;>"ALL") AND (NOT WOW)</Custom>
109-
<Custom Action="AddIisnodeModuleRegistrationWow" After="RemoveIisnodeModuleRegistration">(REMOVE&lt;>"ALL") AND WOW</Custom>
110-
<?else?>
111100
<Custom Action="AddIisnodeModuleRegistration" After="RemoveIisnodeModuleRegistration">REMOVE&lt;>"ALL"</Custom>
112-
<?endif?>
113101
<Custom Action="RollbackAddIisnodeModuleRegistration" After="RemoveIisnodeModuleRegistration">REMOVE&lt;>"ALL"</Custom>
114102
<Custom Action="UndoAddIisnodeModuleRegistration" After="RemoveIisnodeModuleRegistration">REMOVE="ALL"</Custom>
115103

Diff for: src/setup/iisnode-msi/iisnodefiles64wow.wxi

-12
Original file line numberDiff line numberDiff line change
@@ -23,17 +23,6 @@
2323
</Directory>
2424
</DirectoryRef>
2525
</Fragment>
26-
<Fragment>
27-
<DirectoryRef Id="inetsrvdirwow">
28-
<Directory Id="dirC3B05243102F810BD3959CD3BA949E89" Name="config">
29-
<Directory Id="dirC3B05243102F810BD3959CD3BA949E90" Name="schema">
30-
<Component Win64="yes" Id="cmpBFBC3A88B5FB1B48E1CB3DBC62C46CAD" Guid="*">
31-
<File Id="fil98FE22082D3964939C1CB4060FC2A0C7" KeyPath="yes" Source="$(var.wowsourcedir)\iisnode_schema_x64_wow.xml" Name="iisnode_schema.xml"/>
32-
</Component>
33-
</Directory>
34-
</Directory>
35-
</DirectoryRef>
36-
</Fragment>
3726
<Fragment>
3827
<DirectoryRef Id="iisnoderootdirwow">
3928
<Component Win64="yes" Id="cmpF6505586D2A7DD2F0C68235A8CA281C6" Guid="*">
@@ -71,7 +60,6 @@
7160
<ComponentGroup Id="allfileswow">
7261
<ComponentRef Id="cmp1C33C88432AB7530411D254B8656120B"/>
7362
<ComponentRef Id="cmp1C33C88432AC7530411D254B8656120B" />
74-
<ComponentRef Id="cmpBFBC3A88B5FB1B48E1CB3DBC62C46CAD" />
7563
<?if $(var.Configuration) = Debug ?>
7664
<ComponentRef Id="cmpE429AFB5AD377FF35803A538B9BE37A8" />
7765
<?endif?>

0 commit comments

Comments
 (0)