Skip to content

Commit 6664498

Browse files
anoobsdavem330
authored andcommitted
packet: call fanout_release, while UNREGISTERING a netdev
If a socket has FANOUT sockopt set, a new proto_hook is registered as part of fanout_add(). When processing a NETDEV_UNREGISTER event in af_packet, __fanout_unlink is called for all sockets, but prot_hook which was registered as part of fanout_add is not removed. Call fanout_release, on a NETDEV_UNREGISTER, which removes prot_hook and removes fanout from the fanout_list. This fixes BUG_ON(!list_empty(&dev->ptype_specific)) in netdev_run_todo() Signed-off-by: Anoob Soman <anoob.soman@citrix.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 3d9e133 commit 6664498

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

net/packet/af_packet.c

+1
Original file line numberDiff line numberDiff line change
@@ -3952,6 +3952,7 @@ static int packet_notifier(struct notifier_block *this,
39523952
}
39533953
if (msg == NETDEV_UNREGISTER) {
39543954
packet_cached_dev_reset(po);
3955+
fanout_release(sk);
39553956
po->ifindex = -1;
39563957
if (po->prot_hook.dev)
39573958
dev_put(po->prot_hook.dev);

0 commit comments

Comments
 (0)