Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement suggestion: JSON schema valid #3

Open
gamebak opened this issue Jun 20, 2019 · 2 comments
Open

Improvement suggestion: JSON schema valid #3

gamebak opened this issue Jun 20, 2019 · 2 comments

Comments

@gamebak
Copy link

gamebak commented Jun 20, 2019

Hey,

I really like what you did, but maybe you can take the time to make this a valid JSON for Graphql as well?

What I mean by that:
"id >": 1 to also be similar to "id_gt": 1
Proposing suffixes: _gt (greater then), _lt (lower then), _ge (greater or equal), _le (lower or equal), _notin, _in

What do you think about this?

@ivan-kleshnin
Copy link

ivan-kleshnin commented Oct 15, 2019

@gamebak I was going to suggest the same... Which library do you use now? Looks like a very common use case but I can't easily find a tool for the job.

@gamebak
Copy link
Author

gamebak commented Oct 15, 2019

@ivan-kleshnin I used knex-filter because it was quite easy, and to make this work with graphql we used a simple string conversion. The client has to encode it as string from json and the server to decode it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants