Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gRPC #644

Open
6 tasks
TheMrSheldon opened this issue May 24, 2024 · 0 comments
Open
6 tasks

Remove gRPC #644

TheMrSheldon opened this issue May 24, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request python Pull requests that update Python code

Comments

@TheMrSheldon
Copy link
Member

TheMrSheldon commented May 24, 2024

The gRPC endpoints are completely legacy and only used by the runners (in the pipelines folder). They amount for a large part of legacy code that should also be removed as part of this ticket. AFAIK at least the following files should be modified or removed:

  • application/src/run_grpc_server.py
  • gRPC endpoints in application/src/tira/urls.py and large parts of vm_api since they are only used by the gRPC endpoints
  • the runners in pipelines/src/bash -- the python3 snippets may possibly be removed with wget or curl to our REST-API
  • The entire protocol folder since it only contains the gRPC definitions and its generated output
  • Remove reroute_host in application/src/tira/util.py
  • Remove grpc_host setting from the django configs

The gRPC endpoints that can not be deleted without substitution should be replaced using REST endpoints. If none of the REST endpoints in our current specification (documentation/development/specification/rest-api.yml) fit the need, please add these endpoints to the specification in compliance with our REST-API guidelines (https://tira-io.github.io/tira/nightly/development/specification/restapi.html).

@TheMrSheldon TheMrSheldon added enhancement New feature or request python Pull requests that update Python code labels May 24, 2024
@TheMrSheldon TheMrSheldon added this to the ECIR Tutorial 2025 milestone May 24, 2024
@TheMrSheldon TheMrSheldon self-assigned this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Development

No branches or pull requests

1 participant