Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Pooling Parameterizable #11

Open
janheinrichmerker opened this issue Nov 13, 2024 · 2 comments
Open

Make Pooling Parameterizable #11

janheinrichmerker opened this issue Nov 13, 2024 · 2 comments
Assignees

Comments

@janheinrichmerker
Copy link
Contributor

Currently, there are some hard-coded configurations and other issues in the pooling code:

  • The Elasticsearch connection and index to get passage IDs by document ID are hard-coded
  • Some paths are hard-coded.
  • The set of retrieval models and re-rankers is hard-coded.

I believe we should move the configuration to the CLI options and ideally not directly rely on Elasticsearch at all (e.g., by directly retrieving from the segmented corpus).

@janheinrichmerker
Copy link
Contributor Author

I addressed some of the issues in commits:

@mam10eks
Copy link
Member

Awesome, yes, makes sense.

I will modify this to be non-hard coded for the next iteration that I will create on friday

@mam10eks mam10eks self-assigned this Nov 14, 2024
@mam10eks mam10eks changed the title Fix pooling Make Pooling Parameterizable Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants