Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: mime #2

Open
richajak opened this issue Oct 23, 2021 · 6 comments
Open

suggestion: mime #2

richajak opened this issue Oct 23, 2021 · 6 comments

Comments

@richajak
Copy link

Hi @talentlessguy thanks for all the hard work done with tinyhttp I have a suggestion, should the 'mime-db' dependency be replaced with something lighter and still able to handle majority of file extensions, such as mime/lite or mrmime ?

https://github.com/broofa/mime/lite
https://github.com/lukeed/mrmime

Thanks

@talentlessguy
Copy link
Member

mrmime looks good, I'll try to replace es-mime-type with that

@talentlessguy
Copy link
Member

@richajak this is currently blocked by lukeed/mrmime#2

@psulek
Copy link

psulek commented Oct 17, 2022

@talentlessguy cant u just use that charset function you mention directly in your package?
Because using es-mime-types depending on file mime-db\db.json which is ~180kb.
Thats hell too much.

@talentlessguy
Copy link
Member

@psulek yeah I'm going to use mrmime with custom charset func, working on it now

@talentlessguy
Copy link
Member

@psulek mrmime has a too different api, same with mime... could you please create a pull request using either of those?

@psulek
Copy link

psulek commented Jan 5, 2023

I can look at it tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants