Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image: fix interface #382

Merged
merged 1 commit into from
Mar 10, 2022
Merged

image: fix interface #382

merged 1 commit into from
Mar 10, 2022

Conversation

sago35
Copy link
Member

@sago35 sago35 commented Feb 20, 2022

This PR fixes the interface that was discussed in #363.

The test is not OK yet, but it is the same as the Go standard test result, so we won't deal with it here.

sago3@B450GT3 MINGW64 ~/dev/src/tinygo.org/x/drivers (fix-interface)
$ cd image/png/ && tinygo test
FAIL    tinygo.org/x/drivers/image/png  0.156s
FAIL

sago3@B450GT3 MINGW64 ~/dev/src/tinygo.org/x/drivers/image/png (fix-interface)
$ cd ../jpeg/ && tinygo test
ld.lld: error: undefined symbol: time.startTimer
>>> referenced by C:\Go\src\time\sleep.go:96
>>>               C:\Users\sago3\AppData\Local\Temp\tinygo2750643149\main.o:(tinygo.org/x/drivers/image/jpeg.TestLargeImageWithShortData)
failed to run tool: ld.lld
error: failed to link C:\Users\sago3\AppData\Local\Temp\tinygo2750643149\main.exe: exit status 1
FAIL

@deadprogram
Copy link
Member

Thanks for the fix here @sago35 now merging.

@deadprogram deadprogram merged commit 4a336f6 into dev Mar 10, 2022
@deadprogram deadprogram deleted the fix-interface branch March 10, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants