pin: implement driver.Pin interface #215
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pendency on machine package Signed-off-by: deadprogram <[email protected]>
…g of gpio pins before using Signed-off-by: deadprogram <[email protected]>
|
Closing in favor of a somewhat different approach once tinygo-org/tinygo#1537 or something else like that exists. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
drivers.Pininterface so that many drivers can remove another dependency on the machine package.The following drivers however still use
machine.Pineach for various reasons:Each of these will require some resolution or just leave them how they are.
The drivers that use the new pin interface each has a very rudimentary unit test in place to serve as a starting point for more complete testing of that driver.
The new
make unit-testtask run the units for all drivers except those that have dependencies onmachine.