comboat: duplicate methods "execute" and "send"

[deadprogram]

The "execute" and "send" methods for this driver have the exact same implementation

drivers/comboat/comboat.go

Line 142 in 06dd60f

func (d *device) execute(cmd string, timeout int) (err error) {

[deadprogram]

cc @scottfeldman 😄

[scottfeldman]

They are very close, but not the same. execute() waits for "OK", send() waits for ">". I thought about combining them into one func, but that would cause problems if a sending process see's the OK from another process that's executing a cmd, like creating another socket.

Maybe there is a way to DRY the duplicated parts of send() and execute()?

[scottfeldman]

I thought about combining them into one func, but that would cause problems if a sending process see's the OK from another process that's executing a cmd, like creating another socket.

[Caffeine kicking in]...scratch that thought...the two competing processes are mutual ex due to d.Lock().

But I still like being explicit about expected result after an execute() cmd vs. a send() cmd. Maybe the code just needs a // comment covering this?