Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve detection of sources #102

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alexfernandez
Copy link

Description

Detection of sources in analytics_sources.pipe is done using the current domain from the first line. This works fine on setups where there is only a single source, but when there are many it can lead to false positives: the current domain may change from line to line. We want to detect the current domain from each event.

Fixes #101

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tested in a test project (server gcp-wadus6). Events are processed correctly.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have update the CHANGELOG
  • New and existing unit tests pass locally with my changes

@alexfernandez alexfernandez requested a review from sdairs as a code owner October 21, 2024 09:36
Copy link

vercel bot commented Oct 21, 2024

@alexfernandez is attempting to deploy a commit to the tinybird Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Detect multiple sources correctly
1 participant