Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colours for odd and even lines? #8

Closed
knezi opened this issue Jul 12, 2020 · 1 comment · Fixed by #9
Closed

Colours for odd and even lines? #8

knezi opened this issue Jul 12, 2020 · 1 comment · Fixed by #9

Comments

@knezi
Copy link
Contributor

knezi commented Jul 12, 2020

Hi,

I was just wondering why you chose to alternate base03 and base00 for suggestions, tabs... These two are quite different and it's not very comfortable to work with them.

Also, If I get it right, according to Styling Guidelines (http://chriskempson.com/projects/base16/) default BG is base00 and lighter BG is base01. Base03 is IMO for different things.

Am I missing something?
@theova theova mentioned this issue Jul 15, 2020
Merged
@theova theova linked a pull request Jul 15, 2020 that will close this issue
Adjust odd background color #9
Merged
@theova
Copy link
Contributor

theova commented Jul 15, 2020 •
edited
Loading

Hi @knezi ,

Thanks for this issue. Indeed base01 may be better suited than base03.

I've added a pull request (#9) where the proposed changes are implemented. Feel free to comment if it still misses something.

@theova theova closed this as completed in #9 Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adjust odd background color tinted-theming/base16-qutebrowser
2 participants
@knezi @theova