From 09a951db77feff8e4c0477d053ba37969a9f89c3 Mon Sep 17 00:00:00 2001 From: Fabian Meumertzheim Date: Fri, 17 Mar 2023 17:39:09 +0100 Subject: [PATCH] Rename `error` script in `go_cross_binary` (#3481) It confused users that this rule always created a file called `error`. --- go/private/rules/cross.bzl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/go/private/rules/cross.bzl b/go/private/rules/cross.bzl index d98e2f656d..961e365165 100644 --- a/go/private/rules/cross.bzl +++ b/go/private/rules/cross.bzl @@ -42,11 +42,11 @@ def _error_script(ctx): ctx.attr.target.label, ) if _is_windows(ctx): - error_script = ctx.actions.declare_file("error.bat") + error_script = ctx.actions.declare_file("fake_executable_for_bazel_run.bat") ctx.actions.write(error_script, WINDOWS_ERR_SCRIPT.format(errmsg), is_executable = True) return error_script - error_script = ctx.actions.declare_file("error") + error_script = ctx.actions.declare_file("fake_executable_for_bazel_run") ctx.actions.write(error_script, UNIX_ERR_SCRIPT.format(errmsg), is_executable = True) return error_script