misc TODO

[timotheecour]

• # xxx: fix this pre-existing bug causing SuccessX error messages to lie

[timotheecour]

• Merging, but this needs a changelog entry and needs to be documented well.
  CT sizeof(+friends) for {.importc, completeStruct.} types, enable ABI static checks nim-lang/Nim#13926 (comment)
  CT sizeof(+friends) for {.importc, completeStruct.} types, enable ABI static checks

[timotheecour]

revive [TODO] unittest: add optional msg to check, require by timotheecour · Pull Request #10558 · nim-lang/Nim

eg use case: see https://github.com/nim-lang/Nim/pull/14102/files, see this comment for justification: nim-lang#14102 (comment)

[timotheecour]

mv changelog, see nim-lang#14098 (comment)

[timotheecour]

• nimvm: CritBitTree does not work: "limited VM support for 'addr'" · Issue #14339 · nim-lang/Nim

[timotheecour]

• repr shd use addQuoted, see Small improvements for string and char repr with gc:arc by Clyybber · Pull Request #14400 · nim-lang/Nim

Edited:
They are already quoted https://github.com/nim-lang/Nim/pull/14992/files

[timotheecour]

redo profiling after specialize genericReset by Araq · Pull Request #14398 · nim-lang/Nim

[timotheecour]

check whether NRVO suppression impacts performance fixes #14126 [backport:1.2] by Araq · Pull Request #14390 · nim-lang/Nim

[timotheecour]

do TODO from fix #14404 foldr had the classic multiple evaluation bug by timotheecour · Pull Request #14413 · nim-lang/Nim

[timotheecour]

TODO leftover from no more code duplication bw liMessage and rawMessage + several bug fixes by timotheecour · Pull Request #14415 · nim-lang/Nim

I encountered other bugs while fixing this but best to keep this one as mostly refactoring, next one will fix bugs I've encountered (at least they'll only need to be fixed in 1 place)

[timotheecour]

nim-lang@70c289c
testament/testament.nim

revert formatting change Expected: {..} Gotten{..} from this PR

    else:
      maybeStyledEcho fgYellow, "Expected:"
      maybeStyledEcho styleBright, "{", expected, "}\n"
      maybeStyledEcho fgYellow, "Gotten:"
      maybeStyledEcho styleBright, "{", given, "}\n"

[timotheecour]

document gotcha
nim-lang#16182 (comment)

indeed. also noticed in nim-lang#13448. It's so bad that newSeqOfCap should come with a performance warning in its doc comment explaining the newSeqOfCap(n) + seq.add(elem) anti-pattern. This isn't specific to nim.

[juancarlospaco]

• https://github.com/marketplace/actions/todo-to-issue