Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make protoc installation script respect proxy env #512

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mikonse
Copy link
Contributor

@mikonse mikonse commented Apr 8, 2023

see #507

this is a correct version of #508 with a fixed package-lock.json

@@ -1,5 +1,599 @@
{
"name": "@protobuf-ts/protoc",
"version": "2.8.3",
"lockfileVersion": 1
"lockfileVersion": 3,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this will work. CI runs with Node 14.5 (see here), and I don't know at the top of my head if it handles lock file version 3 correctly. Could you use nvm or fnm to switch to the old Node version, and re-create the lock file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've regenerated the lock file using node 14.5, See my latest force push with the updated commit.

@mikonse mikonse force-pushed the proxy-aware-protoc-installation-fixed branch from 8c661cb to 7d1a8ee Compare April 13, 2023 16:23
@mikonse
Copy link
Contributor Author

mikonse commented May 2, 2023

Any update on this? Is there anything I can help with to get this merged?

@RonanRobineau
Copy link

any updates on this? +1 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants