Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duration well known type not supported #365

Closed
delaneyj opened this issue Aug 19, 2022 · 1 comment
Closed

Duration well known type not supported #365

delaneyj opened this issue Aug 19, 2022 · 1 comment
Labels
post-protobuf-es Will be worked on post migration to protobuf-es

Comments

@delaneyj
Copy link

In feature it says

supports all well-known-types with custom JSON representation and helper methods

but google.protobuf.Duration is not supported. It has the same structure as a Timestamp but different contextual meaning.

@timostamm timostamm added the post-protobuf-es Will be worked on post migration to protobuf-es label Aug 19, 2022
@timostamm
Copy link
Owner

Take a look at how Duration serializes to JSON - it's very different from `Timestamp'. Closing this because "not supported" does not seem accurate - unless a regression somehow slipped by the tests. Please LMK if you are aware of something in that regard.

If you have some ideas for helper functions specific to Duration, I'm all ears (we don't really have any standard except Date, so I've found that a bit difficult without pulling in the kitchen sink). Note that the plan is to switch to the base types of protobuf-es, so the preferable way forward would be to add helpers there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
post-protobuf-es Will be worked on post migration to protobuf-es
Projects
None yet
Development

No branches or pull requests

2 participants