Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: maybe you can support a no-label version? #31

Closed
edwardfxiao opened this issue Jun 13, 2017 · 10 comments
Closed

suggestion: maybe you can support a no-label version? #31

edwardfxiao opened this issue Jun 13, 2017 · 10 comments

Comments

@edwardfxiao
Copy link

supporting icon-only might be helpful for a certain amount of people

@timomeh
Copy link
Owner

timomeh commented Jun 21, 2017

Usually I would refer to #15 (comment) and say that that's not how the guidelines define the material bottom navigation, but I changed my mind on this… at least a bit.

At the moment I can't simply support full customizability, because I tried to be really detailed in my implementation. For example the animations are pixel-perfect, and if I would support something like changing label size (as someone else suggested), the Animations would be totally fucked up.

But after seeing examples of real Apps from Google with the Bottom Navigation (cf. YouTube), I realized they don't use their own BottomNavigation at all. The official Android Libraries for the BottomNavigation aren't really that great, too. I also read/heard good arguments for not using the BottomNavigation as the Guidelines define them.

So, public service announcement: I decided to provide a much more flexible version. Yep, that would also include a no-label version. Making a new version has a high priority for me. But please don't expect a new version in the next two or three weeks or so. I'm also a bit involved in my work and social life. 😄

🎉

@edwardfxiao
Copy link
Author

really glad to hear that! And sure, take your time😄

@deadcoder0904
Copy link

Any update ? Gosh, the labels are annoying coz my Labels are pretty big so the animations look a bit weird 😩

@timomeh
Copy link
Owner

timomeh commented Aug 7, 2017

I'm busy af at the moment, sorry. Will try to do something soon.

@deadcoder0904
Copy link

Its OK. No need to be Sorry 😄
I created my own for my particular use-case
Bdw awesome library just labels are annoying for me 😂 bcz on smaller devices with 5 tabs it looks more weirder
Happy Coding 😃

@raihanrazi
Copy link

Great work on this! Looking forward to the next release. Cheers

@danielcdcj
Copy link

I'm interested in having icon-only tab bar too! Looking forward to the next release. Cheers!

@josephbuchma
Copy link

+1

@timomeh
Copy link
Owner

timomeh commented Feb 26, 2018

I am currently (at this moment) doing a big refactor/rewrite of the whole BottomNavigation. I'll include this feature in the upcoming version.

@timomeh
Copy link
Owner

timomeh commented May 14, 2018

Closed with release of v1.0.0. Check out the docs for IconTab. 🚀

@timomeh timomeh closed this as completed May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants