Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to make write more git diff-friendly #314

Open
IanButterworth opened this issue Nov 22, 2022 · 3 comments
Open

Add option to make write more git diff-friendly #314

IanButterworth opened this issue Nov 22, 2022 · 3 comments

Comments

@IanButterworth
Copy link
Collaborator

IanButterworth commented Nov 22, 2022

The timing comments and sorting of precompile statements by time makes the precompile file a bit unfriendly to git diffs making it tricky to write a bot to update precompile statements.

Perhaps turning those both off could be a kwarg option?

@IanButterworth IanButterworth changed the title Make write more git diff-friendly Add option to make write more git diff-friendly Nov 22, 2022
@timholy
Copy link
Owner

timholy commented Jan 10, 2023

With SnoopPrecompile I am almost tempted to eliminate this aspect of SnoopPrecompile altogether (in v3). (One motivation: #312 (comment)) Thoughts?

@ronisbr
Copy link

ronisbr commented Jan 10, 2023

Hi @timholy !

In my case, if this feature if removed, I will have some problems and probably will need to write precompilation statements manually. The package works by connecting to a database. All the functions depends on an active connection. The connection to database is protected by a password and I do not want to write it down in the source files.

Today, I run SnoopCompile to dump the precompile statements. In this stage, I have a working connection and I manually type the password.

@IanButterworth
Copy link
Collaborator Author

We have a similar use case, where precompile statements are collected on a different machine to where they are executed, but we use --trace-compile directly for that collection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants