MethodError: no method matching String(::Expr)

[letalvoj]

Julia 1.5.4, SnoopCompile 2.7.1

data = SnoopCompile.read("7464124.snoop")
pc = SnoopCompile.parcel(reverse!(data[2]))

yields

ERROR: LoadError: MethodError: no method matching String(::Expr)
Closest candidates are:
  String(::String) at boot.jl:337
  String(::Array{UInt8,1}) at strings/string.jl:39
  String(::Base.CodeUnits{UInt8,String}) at strings/string.jl:77
  ...
Stacktrace:
 [1] parse_call(::String; subst::Array{Pair{String,String},1}, exclusions::Array{String,1}) at /Users/vojtech.letal/.julia/packages/SnoopCompile/Y17OY/src/parcel_snoopc.jl:89
 [2] format_userimg(::Array{String,1}; subst::Array{Pair{String,String},1}, exclusions::Array{String,1}) at /Users/vojtech.letal/.julia/packages/SnoopCompile/Y17OY/src/parcel_snoopc.jl:184
 [3] format_userimg(::Array{String,1}) at /Users/vojtech.letal/.julia/packages/SnoopCompile/Y17OY/src/parcel_snoopc.jl:182

it's this line

SnoopCompile.jl/src/parcel_snoopc.jl

Line 89 in 5ad2f24

name = String(name)::String

Seems like there is a test covering that very method. If I manage to fix that issue I will submit a pr

SnoopCompile.jl/test/colortypes.jl

Line 4 in a75d418

success, line, modsym = SnoopCompile.parse_call("Tuple{typeof(ColorTypes.to_top), Type{C}} where C<:(ColorTypes.Colorant{T, N} where N where T)")

[letalvoj]

Ok. These should be all Symbol according to the test suite. I have no idea why I get Expr there.
The snooped compilation is pretty large and it uses macros, Flux, HTTP, ... 🤷

[letalvoj]

A workaround which might just produce incorrect results yet it works for what I needed it to was to replace

name = String(name)::String

with

name = string(name)::String

[timholy]

I'd be fine with a PR that does that, especially if it came with a test! I don't know how to trigger this, but if you do...

[letalvoj]

Yeah, it's most likely wrong for the ::Expr type ... If I fix it such that it makes sense I'll send a PR for sure 👍

[pkofod]

Yeah, I'm hitting this as well when benchmarking code. I can share a private reproducer if you want @timholy

[timholy]

Yeah, I'd take a reproducer!

[pkofod]

It's not minimal, but I'll e-mail it.

[letalvoj]

@pkofod did you manage to find out the root cause?

[PharmCat]

Hello! Is any thoughts how to fix it locally?

[timholy]

Recommended practice these days is to use SnoopPrecompile. I'd recommend switching.