Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enabled=false only suppresses output, still has overhead #312

Closed
Socob opened this issue Apr 26, 2024 · 1 comment
Closed

enabled=false only suppresses output, still has overhead #312

Socob opened this issue Apr 26, 2024 · 1 comment

Comments

@Socob
Copy link

Socob commented Apr 26, 2024

Using @showprogress enabled=false suppresses output from being printed, but any overhead from updating the Progress object is still there (see e. g. progress_map()). I think enabled=false should make @showprogress a no-op instead, since anything beyond that is just wasted time!

@MarcMush
Copy link
Collaborator

performance has drastically improved with #325, you can open the issue again with a MWE if the overhead still is too high for your usecase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants