Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add yaml support #40

Closed
wants to merge 4 commits into from
Closed

Feature/add yaml support #40

wants to merge 4 commits into from

Conversation

leo-cai-timeplus
Copy link
Contributor

PR checklist:

  • Did you run ClangFormat ?
  • Did you separate headers to a different section in existing community code base ?
  • Did you surround proton: starts/ends for new code in existing community code base ?

Please write user-readable short description of the changes:
add yaml support for proton stream smoke test and a sample 0013_changelog_stream3.yaml

@proton-robot
Copy link
Collaborator

Testing

To test this commit:

  1. Use the AWS KMS key alias/github-testing(this key is in the us-west-2 region of the tp-dev account) to generate the HMAC of the following message

    2c67d527-f11d-4290-b2cb-5757f0fc3ffd

    You can copy and run the following command:

    aws kms generate-mac --key-id 'alias/github-testing' --mac-algorithm HMAC_SHA_256 --message '2c67d527-f11d-4290-b2cb-5757f0fc3ffd' --query Mac --output text

  2. Then reply this issue with a comment with the following content:

    /test <the-generated-MAC-hash>

@qijun-niu-timeplus
Copy link
Collaborator

qijun-niu-timeplus commented Sep 6, 2023 •
edited
Loading

  1. Squash your commits into one single commit before making a pull request.
  2. Follow the branch name convention:
    1. feature/issue-[issue_number]-[simple_description]
    2. bugfix/issue-[issue_number]-[simple_description]
    3. test/issue-[issue_number]-[simple_description]
    4. ci/issue-[issue_number]-[simple_description]
  3. Rebase your pr on latest develop branch before you make it.

qijun-niu-timeplus
qijun-niu-timeplus requested changes Sep 6, 2023
View reviewed changes
tests/stream/helpers/rockets.py
@@ -57,8 +57,10 @@
# import global_settigns

from cgi import test
import datetime, json, getopt, logging, logging.config, math, os, platform, random, requests,signal,subprocess, sys, threading, time, traceback, uuid
import datetime, json, yaml, getopt, logging, logging.config, math, os, platform, random, requests,signal,subprocess, sys, threading, time, traceback, uuid
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicated with line 63

@qijun-niu-timeplus
Copy link
Collaborator

If you want format the code base, it's better to make another to do it.
Mixing the feature change and code format change togather is hard to review.

For smoke test python code formatting is ok. For c++ code, you should change your IDE settings and never format the existing code (new code should follow the code styles).

@qijun-niu-timeplus
Copy link
Collaborator

#45

@jovezhong jovezhong deleted the feature/add-yaml-support branch February 23, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qijun-niu-timeplus qijun-niu-timeplus qijun-niu-timeplus requested changes

@jhao0117 jhao0117 Awaiting requested review from jhao0117

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leo-cai-timeplus @proton-robot @qijun-niu-timeplus