fix(select): 🐛 focus the popover on loop from both ends #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for renderless-components ready! Built with commit 6a12188 https://deploy-preview-159--renderless-components.netlify.app |
anuraghazra
reviewed
Nov 20, 2020
anuraghazra
approved these changes
Nov 20, 2020
navin-moorthy
commented
Nov 20, 2020
| @@ -14,15 +14,11 @@ import { | |||
| export function useSelectListState( | |||
| initialState: SealedInitialState<SelectListInitialState> = {}, | |||
| ): SelectListStateReturn { | |||
| const { | |||
| currentId = null, | |||
There was a problem hiding this comment.
Thats because I removed this !
Now by default current id will be on the first tabbable element as programmed in composite.
There was a problem hiding this comment.
This will only affect the currentValue not the selectedValue.
If the selectedValue is changed, currentId will change on useEffect when visible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #156