Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc(html_root_url) so links from external crates to time work #314

Closed
SergioBenitez opened this issue Mar 4, 2021 · 4 comments
Closed
Labels
A-docs Area: documentation

Comments

@SergioBenitez
Copy link

See https://doc.rust-lang.org/rustdoc/the-doc-attribute.html#html_root_url.

@jhpratt
Copy link
Member

jhpratt commented Mar 4, 2021

While this has been recommended by the API guidelines for quite a while, this recommendation is pending removal; it has already completed FCP and just needs merging. So unless there is something everyone has missed, including during the announced FCP, I'm inclined to close this.

Reference

@jhpratt jhpratt added the A-docs Area: documentation label Mar 4, 2021
@SergioBenitez
Copy link
Author

I've expressed my thoughts in the issue. For concreteness, links to time are currently broken in the development docs because this attribute is missing from time.

@jhpratt
Copy link
Member

jhpratt commented Mar 4, 2021

Ok, I'll wait for some further discussion to take place there. I will refrain from duplicating discussion as well.

@SergioBenitez
Copy link
Author

It looks like the new-ish -Zrustdoc-map lets us fill in the URL on our side. As long as the docs are at docs.rs, this'll do. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: documentation
Projects
None yet
Development

No branches or pull requests

2 participants