Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package requires Laravel framework instead of Illuminate packages #13

Closed
DannyvdSluijs opened this issue Apr 28, 2022 · 3 comments · Fixed by #17
Closed

Package requires Laravel framework instead of Illuminate packages #13

DannyvdSluijs opened this issue Apr 28, 2022 · 3 comments · Fixed by #17

Comments

@DannyvdSluijs
Copy link
Contributor

As highlighted in composer.json

"laravel/framework": "^8.0 || ^9.0"
this package requires laravel/framework.

Trying to use this package in a Luman application is resulting in Illuminate packages being removed and laravel/framework being installed as its replacement causing some application issues.

I think it would be relatively easy to replace the dependencies for the sub packages of Laravel framework. Before creating such an PR I wanted to check if you would be accepting pull requests for this?

@timacdonald
Copy link
Owner

I should be able to do this for sure. Will look at that shortly.

@DannyvdSluijs
Copy link
Contributor Author

I took the time to at least make the code changes that I think should be required in order to support Lumen. Changes still need to be tested.

@timacdonald
Copy link
Owner

Gonna close this one and track in the PR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants