Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LICENSE file to contain boilerplate project owner #533

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

dzmitry-huba
Copy link
Contributor

@dzmitry-huba dzmitry-huba commented Dec 7, 2023

As far as I understand the guidelines and looking at other projects (for example, Apache Kafka) the LICENSE file must contain boilerplate ("Copyright [yyyy] [name of copyright owner]") whereas other project files specific ("Copyright 2019 TiKV Project Authors").

Signed-off-by: Dzmitry Huba [email protected]

As far as I understand the guidelines and looking at other projects (for example, Apache Kafka)
the LICENSE file must contain boilerplate ("Copyright [yyyy] [name of copyright owner]") whereas
other project files specific ("Copyright 2019 TiKV Project Authors").

Signed-off-by: Dzmitry Huba <[email protected]>
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. This is the case.

Thank you!

Signed-off-by: Dzmitry Huba <[email protected]>
@dzmitry-huba
Copy link
Contributor Author

Thank you for prompt review. It looks like currently the CI is broken due to unused import. I've added fix for it as well to be able to merge this change. Can you please look at the change one more time, @tisonkun?

@gengliqi gengliqi merged commit 65a0062 into tikv:master Dec 8, 2023
5 checks passed
@dzmitry-huba dzmitry-huba deleted the license branch December 8, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants