Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quorum change should check read index #345

Closed
BusyJay opened this issue Mar 10, 2020 · 5 comments · Fixed by #363
Closed

Quorum change should check read index #345

BusyJay opened this issue Mar 10, 2020 · 5 comments · Fixed by #363
Labels
Bug Recognized misbehavior.

Comments

@BusyJay
Copy link
Member

BusyJay commented Mar 10, 2020

When quorum changes due to configuration change or quorum function change, read index should be checked eagerly. Otherwise read index will not be advanced until next heartbeat.
@BusyJay BusyJay added the Bug Recognized misbehavior. label Mar 10, 2020
@zd08135
Copy link

zd08135 commented May 6, 2020

Is it solved now?

@BusyJay
Copy link
Member Author

BusyJay commented May 6, 2020

I don't think so.

@zd08135
Copy link

zd08135 commented May 6, 2020

let me read the code first. If no one pick this before I understand it, I want to do some help.

@BusyJay BusyJay mentioned this issue May 9, 2020
Merged
@hicqu
Copy link
Contributor

hicqu commented May 12, 2020

@zd08135 do you get any progress?

@hicqu hicqu mentioned this issue May 14, 2020
Merged
@hicqu
Copy link
Contributor

hicqu commented May 14, 2020

@zd08135 I send a PR to fix it because it's a bug influences all TiKV versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Recognized misbehavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

check pending reads when quorum becomes small hicqu/raft-rs
3 participants
@BusyJay @zd08135 @hicqu