*: add metrics for hotspot cache #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disksing
reviewed
Apr 17, 2018
server/schedule/hot_cache.go
Outdated
| @@ -68,15 +71,19 @@ func (w *HotSpotCache) CheckWrite(region *core.RegionInfo, stores *core.StoresIn | |||
| if hotRegionThreshold < hotWriteRegionMinFlowRate { | |||
| hotRegionThreshold = hotWriteRegionMinFlowRate | |||
| } | |||
| return w.isNeedUpdateStatCache(region, hotRegionThreshold, WriteFlow) | |||
| return w.isNeedUpdateStatCache(region, WrittenBytesPerSec, hotRegionThreshold, value, WriteFlow) | |||
There was a problem hiding this comment.
Do we need metrics for hotRegionThreshold?
Connor1996
reviewed
Apr 18, 2018
server/schedule/hot_cache.go
Outdated
| value, isExist = w.readFlow.Peek(key) | ||
| flowBytes = region.ReadBytes | ||
| } | ||
| func (w *HotSpotCache) isNeedUpdateStatCache(region *core.RegionInfo, flowBytes uint64, hotRegionThreshold uint64, v *core.RegionStat, kind FlowKind) (bool, *core.RegionStat) { |
There was a problem hiding this comment.
please make a more concrete name for v
| hotRegionThreshold = hotWriteRegionMinFlowRate | ||
| } | ||
| return w.isNeedUpdateStatCache(region, hotRegionThreshold, WriteFlow) | ||
| hotRegionThreshold := calculateWriteHotThreshold(stores) |
There was a problem hiding this comment.
missing region.WrittenBytes = WrittenBytesPerSec?
There was a problem hiding this comment.
This is unnecessary.
nolouch
force-pushed
the
add-hot-metrics
branch
from
0f41c16
to
be57eaf
Compare
disksing
reviewed
Apr 24, 2018
server/schedulers/balance_test.go
Outdated
| @@ -986,7 +986,7 @@ func (s *testBalanceHotReadRegionSchedulerSuite) TestBalance(c *C) { | |||
| r := tc.RandHotRegionFromStore(2, schedule.ReadFlow) | |||
| c.Assert(r, NotNil) | |||
| c.Assert(r.GetId(), Equals, uint64(2)) | |||
| c.Assert(r.ReadBytes, Equals, uint64(512*1024)) | |||
| c.Assert(r.ReadBytes, Equals, uint64(512*1024*schedule.RegionHeartBeatReportInterval)) | |||
There was a problem hiding this comment.
I think we can remove this line since we don't update r.ReadBytes any more.
server/schedule/metrics.go
Outdated
| @@ -32,9 +32,17 @@ var ( | |||
| Help: "Bucketed histogram of processing time (s) of finished operator step.", | |||
| Buckets: prometheus.ExponentialBuckets(0.01, 2, 16), | |||
| }, []string{"type"}) | |||
| hotCacheStatusGauge = prometheus.NewGaugeVec( | |||
There was a problem hiding this comment.
Add an empty line above this line.
disksing
approved these changes
Apr 25, 2018
disksing
pushed a commit
to oh-my-tidb/pd
that referenced
this pull request
May 7, 2018
disksing
added a commit
that referenced
this pull request
May 8, 2018
* server: skip check a region if there is already a pending operator. (#1029) * pdctl, api, schedule: pdctl supports scatter region. (#1028) * add change log (#1024) * scheduler: hot write scheduler randomly select the balance strategy (#1034) * *: new store region score function for balance (#1014) * core: adjust capacity to fit for more cases (#1035) * check config validation (#1036) * *: add metrics for hotspot cache (#1027) * Refine install instructions. (#1041) These extra steps can help new users who are perhaps not quite so familiar with Go setup and conventions. * *: add change log for 2.0 GA (#1038) * *: add change log for ga. * scheduler: adjust metrics (#1042) * fix parse error of config.toml (#1043) * server: resign pd leader when it is not same as etcd leader. (#1039) * server: fix the valid scheduler was deleted when start coordinator (#1045) * server: fix the valid scheduler was deleted when start coordinator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.