Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows support: tikv-jemalloc-sys not compiling because sh is not a valid command. #22

Open
dertuxmalwieder opened this issue Mar 25, 2022 · 5 comments

Comments

@dertuxmalwieder
Copy link

While analyzing the issue mentioned in ezrosent/frawk#87, I found that tikv-jemalloc-sys (build.rs) relays on sh during its build process. As jemalloc, more or less, supports native compilation on Windows without any MinGW, bash, or other emulations of Unix-like platforms, I would suggest that the hard-coded sh call gets a forking path for Windows.

@BusyJay
Copy link
Member

BusyJay commented Mar 25, 2022

jemalloc relies on configure to bootstrap the build system, I'm not sure how to do so without sh. I believe jemalloc/jemalloc#303 is required to achieve cross platform support.

@dertuxmalwieder
Copy link
Author

Probably, yes. I admit that I have never tried to use jemalloc itself on Windows, so my initial idea might be wrong indeed.

@ghost
Copy link

ghost commented Dec 14, 2023

@BusyJay Hello, I have installed make on windows via Chocolatey, but still sh is a linux command. Would it be possible to remove sh during a build? Thanks.

@ghost
Copy link

ghost commented Dec 14, 2023

And I don't know what this line is for https://github.com/tikv/jemallocator/blob/main/jemalloc-sys/build.rs#L161, seems like this is blocking for windows as well.

@BusyJay
Copy link
Member

BusyJay commented Dec 15, 2023

You can check https://github.com/jemalloc/jemalloc/blob/dev/INSTALL.md#building-for-windows for prerequisites of Windows platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants