Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging of Attributes #228

Open
DemigodCode opened this issue Jun 15, 2022 · 0 comments
Open

Merging of Attributes #228

DemigodCode opened this issue Jun 15, 2022 · 0 comments

Comments

@DemigodCode
Copy link

DemigodCode commented Jun 15, 2022

I've done a port of Bootstrap-Email (https://github.com/bootstrap-email/bootstrap-email) to PHP.

There's some different behavior between this package and the ruby inlining package.

If I have lets say:

.btn { border: 1px solid transparent; } .btn-colored { border-color: #fff; }

I would expect the ruby result:

border: 1px solid #fff;

What this package generates:

border: 1px solid transparent; border-color: #fff

That will lead to a broken button without border in Outlook and it's duplicated anyway with "transparent" AND "#fff".

Any thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant