Make NullMessageForView respond with a string for embed methods

calebporzio · calebporzio · commit 95ea6bfc5892 · 2017-08-01T17:26:25.000-04:00
diff --git a/src/NullMessageForView.php b/src/NullMessageForView.php
@@ -6,15 +6,10 @@
 
 class NullMessageForView
 {
-    protected $validMethods = [
-        'embed',
-        'embedData',
-    ];
-
     public function __call($method, $params)
     {
-        if (in_array($method, $this->validMethods)) {
-            return $this;
+        if (in_array($method, ['embed', 'embedData'])) {
+            return '';
         }
 
         throw new Exception("MailThief message unable to respond to method call: [${$method}]");

Original file line number	Diff line number	Diff line change
`@@ -6,15 +6,10 @@`
`6`	`6`
`7`	`7`	`class NullMessageForView`
`8`	`8`	`{`
`9`		`- protected $validMethods = [`
`10`		`- 'embed',`
`11`		`- 'embedData',`
`12`		`- ];`
`13`		`-`
`14`	`9`	`public function __call($method, $params)`
`15`	`10`	`{`
`16`		`- if (in_array($method, $this->validMethods)) {`
`17`		`- return $this;`
	`11`	`+ if (in_array($method, ['embed', 'embedData'])) {`
	`12`	`+ return '';`
`18`	`13`	`}`
`19`	`14`
`20`	`15`	`throw new Exception("MailThief message unable to respond to method call: [${$method}]");`