Stars shining through objects

[kek]

Hi, thanks for this plugin which looks really nice!

I'm learning Godot so this might be more of a beginner Godot question. But when I try adding starlight to my scene, the stars are visible through other objects that I placed in the scene. This effect is also visible in the demo project, as shown in the screenshot taken from that. I have a feeling I am missing some basic setting -- I have tried to change the rendering order for my other objects and such but no luck.

[tiffany352]

Are you on Godot 4.3+? There was a change to how shaders work in that version. I haven't put out a new version yet though. The fix should be very simple though. Change this line:

godot-starlight/addons/starlight/Star.gdshader

Line 65 in bc7a4cc

POSITION.z = 1.0 * projected.w;

to this:

	POSITION.z = -1.0 * projected.w;

[kek]

Thanks! Yeah, I'm using the latest Godot. I tried changing the line that you suggest. Unfortunately, when I try that change in the demo project, it just makes the stars invisible.

[aganm]

I figured it out.

tiffany was on the right track, gotta reverse the Z coordinate. But to reverse it is a division:

	POSITION.z = 1.0 / projected.w;

[kek]

That is great. That solution works for me. Thanks for the help @tiffany352 and @aganm!

[KyleKirkpatrick]

	POSITION.z = -1.0 * projected.w;

This was actually the correct fix for me.

[aganm]

Sounds like a bug with Godot engine. I will open an issue.

[tiffany352]

I pushed a bunch of commits with various fixes/improvements, including the suggested fix from the linked issue. I'll put out a new release once I'm a bit more sure I didn't break anything.