-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Correct top-level calls are shown for the vast majority of errors #1379
Conversation
ac4ca42
to
0520788
Compare
🙀 |
What levels of horror is your 🙀 cat experiencing? |
It's a moderate level of horror. I don't know if this scheme could fail in this case, but I would expect tibble to be exemplary, given its place in the tidyverse, and use the conventional If it's very costly to add these arguments, then I'd prefer to see some global state peeking/poking, possibly laid out in a stack (e.g. using the call stack via |
Thanks. I don't believe we ever recurse. For now I'll add a comment that this is an anti-pattern, I'll deal with it as part of the frontend-backend separation. |
Also call
abort()
directly, avoid handling condition objects.This PR uses
my_caller_env()
from c147ebf to automatically retrieve the calling environment for correct error locations. Is there any downside, compared to the recommended approach of passingcaller_env()
across the entire chain of calls?