New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Designing S3 generics for extensibility #112

Open

hadley opened this issue Apr 28, 2020 · 1 comment

Labels

Member

hadley commented Apr 28, 2020 •

edited

Loading

As long as the generic contains ..., R CMD check does not compare the method and generic args. See https://github.com/hadley/s3method for sample package that verifies that.

And R CMD check code (via @jimhester): https://github.com/wch/r-source/blob/7345bdb64fc8f6e30dff7077372137bd0e43fb27/src/library/tools/R/QC.R#L2430-L2434

The text was updated successfully, but these errors were encountered:

Member

DavisVaughan commented Feb 17, 2022

This is not entirely true, see https://github.com/DavisVaughan/methodtest for a counterpoint where ... is in the generic and we still get a warning

hadley added the OOP 🎀 label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment