-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aorsf
engine to rand_forest?
#172
Comments
Hi, thank you for the feature request / PR offer! That looks interesting! I'll leave the issue open and we can look into this in more detail when the rOpenSci review is done and |
Thanks! I am looking forward to working on the PR. |
closed in #211 |
This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Hello, thank you for making this package. It is great to see
tidymodels
expanding into survival!Feature
For
rand_forest
, would you be willing to consider a pull request using theaorsf
R package as an additional engine? (https://github.com/bcjaeger/aorsf)If you approve of me submitting a pull request with this feature, I will
follow the instructions here: https://www.tidymodels.org/learn/develop/models/#add-an-engine
wait until I've made any potential major updates based on ROpenSci's review of
aorsf
before I go ahead and submit the pull request (submission here: aorsf; accelerated oblique random survival forests ropensci/software-review#532)The text was updated successfully, but these errors were encountered: