Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aorsf engine to rand_forest? #172

Closed
bcjaeger opened this issue May 3, 2022 · 4 comments
Closed

Add aorsf engine to rand_forest? #172

bcjaeger opened this issue May 3, 2022 · 4 comments
Labels
feature a feature request or enhancement

Comments

@bcjaeger
Copy link
Contributor

bcjaeger commented May 3, 2022

Hello, thank you for making this package. It is great to see tidymodels expanding into survival!

Feature

For rand_forest, would you be willing to consider a pull request using the aorsf R package as an additional engine? (https://github.com/bcjaeger/aorsf)

If you approve of me submitting a pull request with this feature, I will

@hfrick
Copy link
Member

hfrick commented May 5, 2022

Hi, thank you for the feature request / PR offer! That looks interesting! I'll leave the issue open and we can look into this in more detail when the rOpenSci review is done and aorsf is on CRAN.

@hfrick hfrick added the feature a feature request or enhancement label May 5, 2022
@bcjaeger
Copy link
Contributor Author

bcjaeger commented May 6, 2022

Thanks! I am looking forward to working on the PR.

@hfrick
Copy link
Member

hfrick commented Nov 10, 2022

closed in #211

@hfrick hfrick closed this as completed Nov 10, 2022
@github-actions
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants