forked from DefinitelyTyped/DefinitelyTyped
-
Notifications
You must be signed in to change notification settings - Fork 3
/
dangerfile.ts
76 lines (70 loc) · 3.86 KB
/
dangerfile.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
import fs = require('fs')
import os = require('os')
import path = require('path')
import { markdown, danger, fail } from "danger"
const suggestionsDir = [os.homedir(), ".dts", "suggestions"].join('/')
const lines: string[] = []
const missingProperty = /module exports a property named '(.+?)', which is missing/
if (fs.existsSync(suggestionsDir)) {
lines.push('Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.')
lines.push('The check for missing properties isn\'t always right, so take this list as advice, not a requirement.')
for (const suggestionFile of fs.readdirSync(suggestionsDir)) {
const path = [suggestionsDir, suggestionFile].join('/')
const suggestions = fs.readFileSync(path, "utf8").split('\n').map(x => JSON.parse(x)) as Array<{ fileName: string, ruleName: string, message: string }>
const packageName = suggestionFile.slice(0, suggestionFile.indexOf('.txt'))
const missingProperties: { [s: string]: string[] } = {}
for (const s of suggestions) {
const fileName = s.fileName.slice(s.fileName.indexOf("types/" + packageName + "/") + ("types/" + packageName + "/").length)
const match = s.message.match(missingProperty)
const identifier = match ? match[1] : s.message
if (fileName in missingProperties) {
missingProperties[fileName].push(identifier)
}
else {
missingProperties[fileName] = [identifier]
}
}
const topUnpkgURL = `https://unpkg.com/browse/${packageName}@latest/`;
lines.push("## " + packageName + ` ([<kbd>unpkg</kbd>](${topUnpkgURL}))`)
for (const fileName in missingProperties) {
if (Object.keys(missingProperties).length > 1) {
const originalJS = fileName.replace(".d.ts", ".js")
const unpkgURL = `https://unpkg.com/browse/${packageName}@latest/${originalJS}`
const dtsName = packageName.replace("@", "").replace("/", "__")
const dtsURL = `https://github.com/DefinitelyTyped/DefinitelyTyped/blob/${danger.github.pr.head.sha}/types/${dtsName}/${fileName}`
lines.push(`### ${fileName} ([<kbd>unpkg</kbd>](${unpkgURL}), [<kbd>d.ts</kbd>](${dtsURL}))`);
}
const properties = missingProperties[fileName]
lines.push(`was missing the following properties:
1. ` + properties.slice(0,5).join('\n1. '))
if (properties.length > 5) {
const extras = properties.slice(5)
lines.push(`
<details>
<summary>as well as these ${extras.length} other properties...</summary>
<p>${extras.join(", ")}</p>
</details>
`)
}
}
}
markdown(lines.join('\n'))
}
if (danger.git.created_files.some(f => path.basename(f) === ".editorconfig")) {
fail("A nested .editorconfig file may not be added to a package on DefinitelyTyped. Please respect the root .editorconfig.", danger.git.created_files.find(f => path.basename(f) === ".editorconfig"), 1)
}
// Tell people that they've added @me to their lib and not themselves
const newDTSFiles = danger.git.created_files.filter(f => f.endsWith(".d.ts"))
newDTSFiles.forEach(dts => {
const file = fs.readFileSync(dts, "utf8")
if (file.includes("<https://github.com/me>")) {
fail("This line should have your github username in it, not /me", dts, 3)
}
})
for (const filename of danger.git.modified_files.concat(danger.git.created_files)) {
danger.git.diffForFile(filename).then(d => {
if (d.added.indexOf("\t") > -1) { // This is a dumb check for tabs, in lieu of running `prettier` on the diff'd parts
fail("The root .editorconfig style specifies spaces for whitespace. Please use spaces in new or changed types.", filename, d.after.split("\n").findIndex(e => e.indexOf("\t") > -1) + 1)
}
})
}