Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clang (allowing CLANGDWARF and CLANGPDB) to Linux dev containers #99

Closed
mikebeaton opened this issue Sep 29, 2024 · 6 comments
Closed
Labels
enhancement New feature or request

Comments

@mikebeaton
Copy link

mikebeaton commented Sep 29, 2024

It seems desirable that the Fedora and Ubuntu dev containers include clang (sudo dnf install -y clang llvm lld, sudo apt install -y clang llvm lld), allowing the CLANGDRAWF and CLANGPDB toolchains to be used. Could this be added?

@mikebeaton mikebeaton added the enhancement New feature or request label Sep 29, 2024
@osteffenrh
Copy link
Contributor

Sure. I'll look into it. The containers need an update anyway.

@osteffenrh
Copy link
Contributor

Ubuntu 22 and Fedora 40 dev images now include clang.

@mikebeaton
Copy link
Author

mikebeaton commented Oct 1, 2024

@osteffenrh - Thank you very much for that. Is there any reason not to do fedora-39 and -37 as well (ideally, or at least -39, since it's the current edk2 devcontainer, and already supports CLANDWARF ang CLANGPDB once clang is installed)? That would be very helpful too, if possible.

@osteffenrh
Copy link
Contributor

I am planning to remove those images very soon.
The CI is about to get moved over to the F40 image and I would do the same with the devcontainer image too.

It is just too much work to maintain all those images.

The images were initially intended mainly for the CI and this is where my personal focus is.

Would it be ok for you to use the F40 image instead of the other Fedora ones?

@mikebeaton
Copy link
Author

mikebeaton commented Oct 1, 2024

Yes, esp. if edk2 main image is moving over shortly - no problem - tyvm

@mikebeaton
Copy link
Author

mikebeaton commented Oct 1, 2024

@osteffenrh -

Hi again!

I just looked more carefully at the different images. IMO it would be very useful to add CLANGDWARF and CLANGPDB CI to edk2. I contribute to a fork of edk2 (regularly rebased) which runs CI on XCODE5, VS2019, GCC, CLANGDWARF and CLANGPDB (using GitHub actions image runners, plus containers with what we need installed). I would say this is useful because different toolchains often trap different real coding errors. (As well as checking that toolchains that are meant to be supported stay supported, ofc.)

With this in mind, I believe it would make most sense for (and I should have asked for) clang installs to be added to the -build containers (from which I understand the -dev containers inherit). Sorry I originally asked for -dev, I hadn't fully parsed this inheritance tree up to now. (I am hoping to make a PR to edk2 for CLANGDWARF and CLANGPDB CI in due course.)

Is there any chance of this further update, &/or should I add an additional PR or Issue about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants