Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Upgrade node version #2

Closed
AlanCrevon opened this issue May 6, 2019 · 4 comments
Closed

Upgrade node version #2

AlanCrevon opened this issue May 6, 2019 · 4 comments

Comments

@AlanCrevon
Copy link

Hi @tiangolo !

Thanks for this image which is now part of my workflow 👍

I think it would be nice to get node 11 and node 12 versions for this image. I don't think it requires a lot of modifications, but i don't know how to test everything works as expected with non latin characters (working from France on european projects only).

@tiangolo
Copy link
Owner

Thanks, good idea. I'll try to do it.

@frjtrifork
Copy link

Angular CLI 8+ also does not work with the current release in Docker hub. It uses Node 10.5 - but Angular CLI 8 requires 10.9 or later (latest today is 10.16).
It would be great if you could make a new/updated build of the current version also.

@Fhrost0213
Copy link

Ran into the same issue today trying to upgrade Angular and realizing the latest version of this image doesn't support Angular 8+

@tiangolo
Copy link
Owner

Thanks! And sorry for the long delay. 🙈

I no longer use nor recommend this Docker image, I think you are much better off building a Docker image yourself, so I updated all the docs to explain how to do it: https://github.com/tiangolo/node-frontend

The only extra step is creating and copying a simple nginx.conf file that you can copy-paste.

Given that, I'll now close this one. But thanks for the interest! ☕

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants