Skip to content

🐛 Fix Poetry installation in Dockerfile and upgrade Python version and packages to fix Docker build#480

Merged
tiangolo merged 3 commits intofastapi:masterfrom
little7Li:fix/poetry-installed
Nov 14, 2023
Merged

🐛 Fix Poetry installation in Dockerfile and upgrade Python version and packages to fix Docker build#480
tiangolo merged 3 commits intofastapi:masterfrom
little7Li:fix/poetry-installed

Conversation

@little7Li
Copy link
Contributor

The poetry installation url has to be updated as the old one is no longer valid.
image

And replace a poetry install option --no-dev with a recommended one --only main.
image

@little7Li
Copy link
Contributor Author

#479

@hcristea
Copy link

@little7Li, thanks for the PR, I wanted to do it myself. I'd change the title to something like "Upgrade poetry installer to v1.2" to reflect more accurately the changes. The previous installer for poetry 1.1 works fine, no need to fix it, just make an upgrade.

@kwantopia
Copy link

Would be great if this were merged soon.

@featherware
Copy link

Bump!

The provided URL now breaks build with a 404.

@tiangolo tiangolo changed the title Fix the poetry installation in Dockerfile. 🐛 Fix Poetry installation in Dockerfile and upgrade Python version and packages to fix Docker build Nov 14, 2023
@tiangolo tiangolo added bug Something isn't working investigate and removed investigate labels Nov 14, 2023
@tiangolo
Copy link
Member

Awesome, thank you @little7Li! 😄 🍰

I updated the Python version as well as it was not building the Docker image, and I updated a couple of other dependencies needed for it to build and run. 🤓

Thanks @hcristea for the comment! ☕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants