Skip to content

♻️ Edit refactor db models to use UUID's instead of integer ID's#1259

Merged
tiangolo merged 6 commits intomasterfrom
FL-14-refactor-to-use-uuids
Jul 22, 2024
Merged

♻️ Edit refactor db models to use UUID's instead of integer ID's#1259
tiangolo merged 6 commits intomasterfrom
FL-14-refactor-to-use-uuids

Conversation

@estebanx64
Copy link
Contributor

No description provided.

@tiangolo
Copy link
Member

Great! Thank you @estebanx64! 🚀 ☕

@tiangolo tiangolo enabled auto-merge (squash) July 22, 2024 22:48
@tiangolo tiangolo merged commit e65b427 into master Jul 22, 2024
@tiangolo tiangolo deleted the FL-14-refactor-to-use-uuids branch July 22, 2024 22:49
gpspake added a commit to gpspake/rap901 that referenced this pull request Jul 28, 2024
gpspake added a commit to gpspake/rap901 that referenced this pull request Jul 28, 2024
gpspake added a commit to gpspake/rap901 that referenced this pull request Jul 28, 2024
@dxm1337
Copy link

dxm1337 commented Jul 30, 2024

This might sound a bit off the wall, but this solution really cramps the template's versatility big time. Right now, if I want to switch the DB to MySQL, I'm gonna have to hack my way through it. Meanwhile, UUID doesn’t really add much value.

If I'm off base here, feel free to correct me and steer me right.

d4vidsha added a commit to d4vidsha/scheduler that referenced this pull request Jul 30, 2024
@d4vidsha
Copy link

d4vidsha commented Jul 30, 2024

but this solution really cramps the template's versatility big time.

What do you mean by "this solution"? This PR changes UUIDs for tasks and items, maybe this is a discussion meant for the forums

@dxm1337
Copy link

dxm1337 commented Aug 3, 2024

@d4vidsha
This Pull Request changes the simple and straightforward int to uuid for indexes. From an architectural standpoint, I see no benefits, but I do see drawbacks. The main issue I've pointed out is the now-impossible on-the-fly switch to MySQL. Previously, all I needed to do was install the MySQL driver, add the root password, and modify the connection string. Now, that won't work because MySQL doesn't handle UUIDs directly.

This project is a template built on certain technologies. If needed, I can remove React and replace it with Vue, or swap out another system component. This is correct from an architectural perspective (modularity, freedom of choice). But this PR binds us to PostgreSQL and reduces the template's flexibility.

gusevyaroslove pushed a commit to gusevyaroslove/fastapi-template that referenced this pull request Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants