🚨 Enable ARG001 to prevent unused arguments#1152
Merged
tiangolo merged 2 commits intofastapi:masterfrom Apr 5, 2024
Merged
Conversation
patrick91
changed the title
ARG001 to prevent unused importsARG001 to prevent unused arguments
patrick91
force-pushed
the
feature/remove-unused-arguments
branch
from
3db384f to
3c3cde1
Compare
Member
|
Nice, I like it, thanks! 🚀 |
gusevyaroslove
pushed a commit
to gusevyaroslove/fastapi-template
that referenced
this pull request
Aug 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed in some places we have unused arguments (especially
dbin tests). I'veadded the
ARG001rule to prevent that 😊