🔥 Remove isort configuration, since we use Ruff now#1144
Merged
tiangolo merged 5 commits intofastapi:masterfrom Apr 5, 2024
Merged
🔥 Remove isort configuration, since we use Ruff now#1144tiangolo merged 5 commits intofastapi:masterfrom
tiangolo merged 5 commits intofastapi:masterfrom
Conversation
patrick91
commented
Apr 2, 2024
| patch.object(logger, "error"), | ||
| patch.object(logger, "warn"), | ||
| ): | ||
| try: |
Contributor
Author
There was a problem hiding this comment.
these changes are due to running sh scripts/format.sh :)
Contributor
|
@patrick91 format.sh can be removed, if you see lint.sh is doing what you wrote in format.sh and was called just by format-import.sh which was removed in your PR too |
Member
|
Great, thanks @patrick91! 🚀 I restored |
gusevyaroslove
pushed a commit
to gusevyaroslove/fastapi-template
that referenced
this pull request
Aug 4, 2024
Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
|
@patrick91 I've identified bug when running I think we need to remove I can push this small fix if this makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the isort configuration from pyproject.toml
The configuration options we had set aren't supported by ruff just yet,
but I think the default config is pretty much what we want (after all
running ruff now didn't change anything).
I'm also removing the calls to isort, since we want to use ruff for this.
I've also update the
format.shscript to use ruff, do we want to keep it?