Skip to content

Relax hard-pinning of starlette#1555

Closed
dhirschfeld wants to merge 1 commit intofastapi:masterfrom
dhirschfeld:patch-1
Closed

Relax hard-pinning of starlette#1555
dhirschfeld wants to merge 1 commit intofastapi:masterfrom
dhirschfeld:patch-1

Conversation

@dhirschfeld
Copy link

starlette is up to 0.13.4 now.

Unless a specific patch release is actually a hard requirement it's more user-friendly to pin to a compatible release so as to automatically benefit from bug/security fixes.

@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

Merging #1555 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1555   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          230       230           
  Lines         6862      6862           
=========================================
  Hits          6862      6862           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 072c2bc...d1459de. Read the comment docs.

@tiangolo
Copy link
Member

Thanks! Yep, the problem is that as FastAPI is very tightly integrated with Starlette, there could be (and have been) breaking changes very easily, even for patch releases 😔

For Pydantic it's possible to have more relaxed pinning mainly because Pydantic runs all of FastAPI's tests as part of its own CI tests.

On the other hand, I'm thinking of migrating from Flit to Poetry, that way I could set up Dependabot to make it send PRs for each new version.

But for the time being, I have to keep the strict pinning...

Anyway, thanks for your contribution! And for all the management in Conda Forge! 🙇 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants