Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the "Finish" button of the same size in chapters #296

Closed
Prakhar-Agarwal-byte opened this issue Apr 8, 2023 · 5 comments · Fixed by #300 or #311
Closed

Make the "Finish" button of the same size in chapters #296

Prakhar-Agarwal-byte opened this issue Apr 8, 2023 · 5 comments · Fixed by #300 or #311
Milestone

Comments

@Prakhar-Agarwal-byte
Copy link
Contributor

The Finish button here is smaller than the Prev and Next buttons.

WhatsApp Image 2023-04-08 at 2 40 27 PM

We should make it the same size as the other buttons.

@Prakhar-Agarwal-byte
Copy link
Contributor Author

I think the difference in size is due to the icons in Prev and Next buttons. I will add some padding in the Finish button to fix this.

@thunderbiscuit
Copy link
Owner

Yes something about the way the weight is distributed between the two buttons I think might be the cause. Somehow the "Prev" button keeps the same size across devices and the other button always just uses whatever space is left (not sure about this, just a feeling).

@thunderbiscuit
Copy link
Owner

On my emulator it looks like this is not yet fixed. The buttons are closer in size, but not identical by default (and I don't think they're the same length).

I think the issue is that the fix in #300 is hard-coding a padding value, but that won't really fix the issue on all screen sizes.

@fivetran-tangyetong
Copy link
Collaborator

fivetran-tangyetong commented Apr 12, 2023

My bad, totally forgot about padding potentially being different for all screen sizes.

There should be a few good alternative ways of solving this (both prev and next buttons using the same row and filling up height etc..)

@thunderbiscuit
Copy link
Owner

Yeah agreed, I think the idea of the two buttons sharing a row and filling up the height + using each the same width proportion inside the row makes sense and will ensure they always just look the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants