Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StandardShadow doesn't work on older Android versions #236

Open
thunderbiscuit opened this issue Jan 2, 2023 · 7 comments
Open

StandardShadow doesn't work on older Android versions #236

thunderbiscuit opened this issue Jan 2, 2023 · 7 comments
Labels
bug Something isn't working right ui User interface
Milestone

Comments

@thunderbiscuit
Copy link
Owner

No description provided.

@thunderbiscuit thunderbiscuit added bug Something isn't working right ui User interface labels Jan 2, 2023
@BhuvanAde
Copy link

Hey @thunderbiscuit, I'm Bhuvan Ade. A UI/UX Designer Can I please work on this issue?

@thunderbiscuit
Copy link
Owner Author

Hi @BhuvanAde. You are more than welcome to investigate, but I do think that it's a rather technical issue related to the Compose compiler and compatibility with older Android APIs. If you are an UI/UX designer, I'm not sure this issue is the perfect fit for you. I also didn't put any extra comment there, so I do wonder if maybe you thought it was something else than what the bug actually is. Let me know if you want more explanations.

@thunderbiscuit thunderbiscuit added this to the v1.0.0 milestone Jan 24, 2023
@thunderbiscuit
Copy link
Owner Author

APIs tested

  • 26
  • 27
  • 28
  • 29
  • 30 — Bug is present
  • 31 — Not a problem
  • 32
  • 33 — Not a problem

@BhuvanAde
Copy link

@thunderbiscuit Please let me know if there are any issues related to UI/UX. I would love to do that!

@thunderbiscuit
Copy link
Owner Author

At the moment there isn't much, as I'm sort of repositioning the project towards cleaning up some technical debt and preparing for the 1.0 release. You can keep an eye on the issues I tagged for the 1.0 milestone here. There isn't much, but hopefully we add a few as bug reports come in!

If you'd like to try the latest version in the Play Store and play around with it, you can also open up issues on the repo with small UI issues and suggestions (for example I'm not sure how the app looks on very small screens or very large ones, so if you have access to that you could share screenshots of UI breaks if there are any).

@yellowHatpro
Copy link
Contributor

standardShadow is an extension function that is based on advancedShadow modifier right?

@yellowHatpro
Copy link
Contributor

I am not able to figure out the expected and actual behavior ( I am on Android 11). Here is what I can see from Cancel button that seems to use standardShadow
issue#236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working right ui User interface
Projects
None yet
Development

No branches or pull requests

3 participants