Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial focus in message compose screen #7635

Open
cketti opened this issue Feb 13, 2024 · 1 comment · May be fixed by #8664
Open

Initial focus in message compose screen #7635

cketti opened this issue Feb 13, 2024 · 1 comment · May be fixed by #8664
Labels
type: enhancement New features or improvements to existing features.

Comments

@cketti
Copy link
Member

cketti commented Feb 13, 2024

When opening the message compose screen, the focus should be on the first empty input field of "To", "Subject", and "Message text" (in that order).

This should do the right thing no matter what action lead to opening the message compose screen (compose, reply, forward, edit draft, mailto: URI)

See also #7618

@cketti cketti added the type: enhancement New features or improvements to existing features. label Feb 13, 2024
@cketti
Copy link
Member Author

cketti commented Feb 14, 2024

@LorenzHo: For a proper fix I suggest extracting the initFromIntent() code to a separate (Kotlin) file in the com.fsck.k9.ui.compose package. Instead of calling methods on RecipientPresenter, AttachmentPresenter, etc., the code should return a data class containing the properties that have been extracted from the Intent. Then the calling code in MessageCompose will use the result to issue the appropriate calls to the presenters.

That should also allow us to write tests for the code to extract data from Intents.

@shamim-emon shamim-emon linked a pull request Dec 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New features or improvements to existing features.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant