Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thunder does not load images in comments on instances that proxy images #1527

Open
x4740N opened this issue Aug 13, 2024 · 2 comments
Open
Assignees
Labels
bug Something isn't working lemmy-server Potentially requires or depends on changes from the Lemmy server side

Comments

@x4740N
Copy link

x4740N commented Aug 13, 2024

Bug Description

On instances such as lemm.ee where images are proxied thunder fails to load them

SmartSelect_20240814-012809_Thunder
Screenshot_20240814-012722_Thunder
SmartSelect_20240814-012709_Thunder

Expected Behaviour

Thunder should load images correctly

Steps to Reproduce

Try to open any image in a comment on a lemmy instance that proxies images such as lemm.ee

Additional Context

No response

App Version

v 0.5-6

Device

Samsung Galaxy A70

OS

Android 11

@x4740N x4740N added the bug Something isn't working label Aug 13, 2024
@hjiangsu
Copy link
Member

Thanks for the report! I forgot to apply the same logic for proxied images in the markdown. I'll apply a patch for this in the general release for v0.5.0.

@hjiangsu hjiangsu self-assigned this Aug 13, 2024
@hjiangsu hjiangsu added the fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version label Aug 13, 2024
@hjiangsu hjiangsu added this to the 0.5.0 milestone Aug 13, 2024
@hjiangsu hjiangsu removed the fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version label Aug 13, 2024
@hjiangsu
Copy link
Member

Just a quick update here - it seems like the underlying issue is not with Thunder, but with Lemmy itself. If you visit the comment on Lemmy UI, you'll see that the image is not present there either.

This could likely be an issue with how image proxy handles svg images?

@hjiangsu hjiangsu removed this from the 0.5.0 milestone Aug 15, 2024
@hjiangsu hjiangsu added the lemmy-server Potentially requires or depends on changes from the Lemmy server side label Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lemmy-server Potentially requires or depends on changes from the Lemmy server side
Projects
None yet
Development

No branches or pull requests

2 participants